Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to address the drift issue on reonboard with impersonation for GKE clusters. Key changes include:
- Updating the log message and drift detection handling in resourceCastaiGKEClusterRead.
- Removing the automatic reset of credentials in favor of a simple warning.
- Improving error handling in resourceCastaiGKEClusterDelete by returning the error diagnostic.
Comments suppressed due to low confidence (1)
castai/resource_gke_cluster.go:155
- Removing the automatic reset of FieldGKEClusterCredentials (previously setting it to 'credentials-drift-detected-force-apply') may leave the cluster in a drifted state if the credentials aren’t manually reapplied. Consider adding documentation or alternative logic to ensure credentials are reapplied where needed.
log.Printf("[WARN] Drift detected in credentials_id. State: %q, API: %q. Consider reapplying credentials.", data.Get(FieldClusterCredentialsId), *resp.JSON200.CredentialsId)
ValyaB
changed the title
|
This PR has been labeled as stale due to inactivity and will be closed in 7 days if no further activity occurs. |
|
This PR has been closed due to inactivity. Feel free to reopen if you are still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.